Hi Joe, On Mon, Dec 12, 2011 at 03:44:53PM -0800, Joe Perches wrote: > On Tue, 2011-12-13 at 00:06 +0100, roel wrote: > > The test not [val1] or not [val2] always evaluates to true > > Hey Jamie and Roel > > Looking at drivers with: > > $ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\|\|\s*\1\s*\!\=" drivers > > drivers/crypto/picoxcell_crypto.c: if ((len != AES_KEYSIZE_128 || len != AES_KEYSIZE_256) && > drivers/crypto/picoxcell_crypto.c: } else if ((len != AES_KEYSIZE_128 || len != AES_KEYSIZE_256) && > > Most likely these should be && not ||. Yup, the original code was incorrect. Patch to follow. Thanks Joe! Jamie -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
