Re: [PATCH 02/16] MPILIB: Add a missing ENOMEM check [ver #2]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/29/2011 05:43 PM, David Howells wrote:
Add a missing ENOMEM check.

Signed-off-by: David Howells<dhowells@xxxxxxxxxx>
---

  lib/mpi/mpicoder.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)


diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
index fe84bb9..6e225a8 100644
--- a/lib/mpi/mpicoder.c
+++ b/lib/mpi/mpicoder.c
@@ -255,6 +255,8 @@ void *mpi_get_buffer(MPI a, unsigned *nbytes, int *sign)
  	if (!n)
  		n++;		/* avoid zero length allocation */
  	p = buffer = kmalloc(n, GFP_KERNEL);
+	if (p<  0)
+		return NULL;

Sorry, maybe i'm having a confused morning, but shouldn't this check be for p==NULL rather than p<0?


  	for (i = a->nlimbs - 1; i>= 0; i--) {
  		alimb = a->d[i];

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux