Jamie Iles wrote at Friday, November 18, 2011 3:03 AM: > On Fri, Nov 18, 2011 at 11:12:33AM +0530, Varun Wadekar wrote: > > driver supports ecb/cbc/ofb/ansi_x9.31rng modes, > > 128, 192 and 256-bit key sizes > > +static int tegra_aes_probe(struct platform_device *pdev) ... > > + dev_info(dev, "registered"); > > + return 0; > > + > > +out: > > + for (j = 0; j < i; j++) > > + crypto_unregister_alg(&algs[j]); > > + if (dd->ivkey_base) > > + dma_free_coherent(dev, AES_HW_KEY_TABLE_LENGTH_BYTES, > > + dd->ivkey_base, dd->ivkey_phys_base); > > + if (dd->buf_in) > > + dma_free_coherent(dev, AES_HW_DMA_BUFFER_SIZE_BYTES, > > + dd->buf_in, dd->dma_buf_in); > > + if (dd->buf_out) > > + dma_free_coherent(dev, AES_HW_DMA_BUFFER_SIZE_BYTES, > > + dd->buf_out, dd->dma_buf_out); > > + if (dd->aes_clk) > > + clk_put(dd->aes_clk); > > Note that clk_get() _can_ return NULL as a valid clk even if it doesn't > on tegra which makes this check a little difficult. You can use IS_ERR to check for whether the clock was "got" or not, but of course, you'll have to initialize that field to some error value before any point where the code can "goto out"; -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
