Varun Wadekar wrote at Monday, November 14, 2011 9:20 PM: > The crypto driver will need this api to use > it in the RNG calculations. In order to build > the crypto driver as a module, tegra_chip_uid > has to be exported. > > Original author: Henning Heinold <heinold@xxxxxxxxxxxxxxxx> You should drop that line from the patch description, and fix the git author field for the commit so that it reflects that Henning wrote this. If this commit is HEAD, you'd run: git commit --amend --author='Henning Heinold <heinold@xxxxxxxxxxxxxxxx>' If the commit isn't HEAD, you'll need to run "git rebase -i X", choose "edit" for this commit, then run the "git commit --amend" command above once you're at this commit. Finally, run "git rebase --continue". "X" in the above command is the commit ID immediately preceding this current commit in your git history. Second, this patch is really part of a 2-patch series beginning with this patch, and ending with the Tegra AES driver implementation. You should generate and email out the two patches together, and to the same set of people, so it's clear they're related. That way, they'll typically always be applied in sequence to the same git tree. Mail me internally if you need help with this. (BTW, Colin Cross is also a Tegra maintainer. He should be CC'd on Tegra patches too; see the output from scripts/get_maintainer.pl as a guide) My inclination is that you'll need to repost to fix at least the git author field, but I'd probably wait a little to see if there's any further feedback on the AES driver first. -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
