Re: [PATCH v4 00/17] crypto user configuration api

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 27, 2011 at 07:20:50AM +0200, Steffen Klassert wrote:
> This patchset adds a netlink based user configuration API for the crypto
> layer, similar to the configuration API of xfrm.

All applied to cryptodev.  Thanks!

I added this little fix on top:

commit e6ea64ece7f4c14294b2fce5403b1e71eab87f1e
Author: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date:   Fri Oct 21 14:37:10 2011 +0200

    crypto: user - Initialise match in crypto_alg_match
    
    We need to default match to 0 as otherwise it may lead to a false
    positive.
    
    Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

diff --git a/crypto/crypto_user.c b/crypto/crypto_user.c
index 748990f..2abca78 100644
--- a/crypto/crypto_user.c
+++ b/crypto/crypto_user.c
@@ -40,7 +40,6 @@ struct crypto_dump_info {
 
 static struct crypto_alg *crypto_alg_match(struct crypto_user_alg *p, int exact)
 {
-	int match;
 	struct crypto_alg *q, *alg = NULL;
 
 	down_read(&crypto_alg_sem);
@@ -49,6 +48,7 @@ static struct crypto_alg *crypto_alg_match(struct crypto_user_alg *p, int exact)
 		return NULL;
 
 	list_for_each_entry(q, &crypto_alg_list, cra_list) {
+		int match = 0;
 
 		if ((q->cra_flags ^ p->cru_type) & p->cru_mask)
 			continue;

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux