Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



James Morris <jmorris@xxxxxxxxx> wrote:

> > +MPI mpi_alloc(unsigned nlimbs)
> > +{
> > +	MPI a;
> > +
> > +	a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
> 
> Generally, typedef structs are frowned upon in the kernel.  I'd prefer to 
> see this (and any others) changed to a normal type.

In this case, however, it makes it easier to compare back to the original
code.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux