Re: [PATCH v3 10/17] crypto: Add userspace report for ablkcipher type algorithms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 21, 2011 at 11:07:16AM +0200, Steffen Klassert wrote:
>
> diff --git a/include/linux/cryptouser.h b/include/linux/cryptouser.h
> index 62ae124..0c359e5 100644
> --- a/include/linux/cryptouser.h
> +++ b/include/linux/cryptouser.h
> @@ -40,6 +40,7 @@ enum crypto_attr_type_t {
>  	CRYPTOCFGA_REPORT_SHASH,	/* struct crypto_report_hash */
>  	CRYPTOCFGA_REPORT_AHASH,	/* struct crypto_report_hash */
>  	CRYPTOCFGA_REPORT_BLKCIPHER,	/* struct crypto_report_blkcipher */
> +	CRYPTOCFGA_REPORT_ABLKCIPHER,	/* struct crypto_report_blkcipher */

I don't think you should distinguish between BLKCIPHER and ABLKCIPHER.
A good rule of thumb would be if the report data structure is the
same, then the type value should be the same.

You can still have the string type to show something different to
the user.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux