On Mon, Aug 29, 2011 at 10:18:18AM +0200, Steffen Klassert wrote:
> On Mon, Aug 22, 2011 at 02:59:01PM +0800, Herbert Xu wrote:
> > On Wed, Aug 17, 2011 at 02:10:13PM +0200, Steffen Klassert wrote:
> > >
> > > +struct crypto_user_alg {
> > > + char cru_name[CRYPTO_MAX_ALG_NAME];
> > > + char cru_driver_name[CRYPTO_MAX_ALG_NAME];
> > > + __u32 type;
> > > + __u32 mask;
> > > +};
> > > +
> > > +#define CRYPTO_MAX_NAME CRYPTO_MAX_ALG_NAME
> > > +
> > > +struct crypto_report_base {
> > > + char name[CRYPTO_MAX_ALG_NAME];
> > > + char driver_name[CRYPTO_MAX_ALG_NAME];
> > > + char module_name[CRYPTO_MAX_NAME];
> > > + char selftest[CRYPTO_MAX_NAME];
> > > + int priority;
> > > + int refcnt;
> > > +};
> >
> > We should use one structure for both creating algorithms and
> > querying them. User-space can leave the query fields blank
> > when creating them.
>
> Do you think about merging the two structures above and to
> keep the algorithm specific structures separate, or to
> merge all of them to one big structure?
>
> I think we would be most flexible if we would merge the two
> structures above and keep the algorithm specific structures
> separate.
As long as we maintain the ability to replay queried results
it should be fine. That is, by sending the result of a dump
to another system you should be able to recreate the original
configuration state.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
