On Sun, Aug 7, 2011 at 1:48 PM, Joachim Eastwood <manabian@xxxxxxxxx> wrote: > > yes, this works. At least my board boots as normal. Ok, I'll remove it for -rc1, just to have a working ARM setup. Maybe we can re-introduce it later (either together with some arm-specific hack for SHA_WORKSPACE_WORDS or by having an arm-optimized version of the *good* sha1 routine). But I doubt it: there used to be an ARM-optimized thing in git too. It was removed two years ago with the commit message: remove ARM and Mozilla SHA1 implementations They are both slower than the new BLK_SHA1 implementation, so it is pointless to keep them around. and quite frankly, that removed code seems to be the same as the in-kernel one. So I bet the ARM "optimized" SHA1 is simply not worth keeping around. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html