I am not talking about user space API at all. I talk about kernel crypto API and kernel clients. Please understand the following: when update() is called driver does not know if it is last update or not... That is essential. If client code would always use update/finup then it is fine.. But original API and clients uses update/final... That is why some way (flag) needed to tell if finup() will be used or not... It gave up 20% performance improvement in some case because no extra memcpy has been done... If you think about other solution, please share... Have a nice day, - Dmitry On 26/01/11 01:29, ext Herbert Xu wrote: > On Tue, Jan 25, 2011 at 03:44:47PM +0200, Dmitry Kasatkin wrote: >> What we have done in our system is introduced a new flag which is set to >> request. >> flags |= CRYPTO_TFM_REQ_USE_FINUP; >> ahash_request_set_callback(req, flags, tcrypt_complete, &tresult); > We don't need a flag for this, we just need to optimise the > user-interface code to actually use finup when MSG_MORE is not > set. > > Cheers, -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
