On 01/06/2011 07:35 AM, Herbert Xu wrote: > On Thu, Jan 06, 2011 at 02:15:16PM +0100, Mario 'BitKoenig' Holbe wrote: >> >> The patch helps. No crashes, meaningful random data - perfect. >> I still have 2 small annotations... > > Thanks for testing! > >> 1. Having ECX on the clobber-list is not really necessary. >> XSTORE doesn't touch ECX at all. >> REP XSTORE would touch it, but for this ECX would be an input anyways. > > The documentation wasn't clear whether ECX would be updated without > the REP prefix so I included it to be on the safe side. Unfortunately > my only VIA machine is on another continent at the moment so I can't > test it myself. Can you verify that ECX isn't changed without the > REP prefix? > >> 2. Would you mind doing the same for EDX as you did for EDI? >> This doesn't really change anything currently, but will probably help >> avoiding a debug-session like ours somewhere in the future :) > > According to my documentation EDX isn't be modified (nor would it > make sense as it would break REP XSTORE). Are you seeing anything > different? As an interested observer, I think this routine needs some really detailed comments. Larry -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
