On Thu, Nov 18, 2010 at 03:44:28PM +0800, Huang Ying wrote: > On Thu, 2010-11-18 at 15:41 +0800, Mathias Krause wrote: > > On 11.11.2010, 23:20 Mathias Krause wrote: > > > The AES-NI instructions are also available in legacy mode so the 32-bit > > > architecture may profit from those, too. > > > > > > To illustrate the performance gain here's a short summary of a dm-crypt > > > speed test on a Core i7 M620 running at 2.67GHz comparing both assembler > > > implementations: > > > > > > x86: i568 aes-ni delta > > > ECB, 256 bit: 93.8 MB/s 123.3 MB/s +31.4% > > > CBC, 256 bit: 84.8 MB/s 262.3 MB/s +209.3% > > > LRW, 256 bit: 108.6 MB/s 222.1 MB/s +104.5% > > > XTS, 256 bit: 105.0 MB/s 205.5 MB/s +95.7% > > > > > > Additionally, due to some minor optimizations, the 64-bit version also > > > got a minor performance gain as seen below: > > > > > > x86-64: old impl. new impl. delta > > > ECB, 256 bit: 121.1 MB/s 123.0 MB/s +1.5% > > > CBC, 256 bit: 285.3 MB/s 290.8 MB/s +1.9% > > > LRW, 256 bit: 263.7 MB/s 265.3 MB/s +0.6% > > > XTS, 256 bit: 251.1 MB/s 255.3 MB/s +1.7% > > > > > > Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx> > > > --- > > > v4 changes: > > > * adapted CBC implementation to be useable on x86, too > > > * redo the measurement using dm-crypt > > > > > > v3 changes: > > > * fixed 32-bit implementation of aesni_ecb_enc (a hunk somehow moved to the end > > > of another function) > > > > > > v2 changes: > > > * hide almost all register names in macros so the same code base can be shared > > > between x86 and x86_64 > > > * unified Kconfig documentation again > > > * added alignment constraints for internal functions. > > > > > > > > > arch/x86/crypto/aesni-intel_asm.S | 197 ++++++++++++++++++++++++++++++------ > > > arch/x86/crypto/aesni-intel_glue.c | 22 +++- > > > crypto/Kconfig | 12 ++- > > > 3 files changed, 191 insertions(+), 40 deletions(-) > > > > No comments so far? :( > > What's wrong with the patch? > > Reviewed-by: Huang Ying <ying.huang@xxxxxxxxx> Patch applied. Thanks a lot everyone! -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
