On Fri, 2010-11-19 at 15:45 +0000, David Howells wrote: > Mimi Zohar <zohar@xxxxxxxxxxxxxxxxxx> wrote: > > > +int tpm_send(u32 chip_num, void *cmd, int buflen) > > I'd recommend size_t for buflen; apart from that: > > Acked-by: David Howells <dhowells@xxxxxxxxxx> right - that would be better. Currently transmit_command() in tpm.c expects an int, but it changes it to size_t for the actual tpm_transmit(). We will work with Rajiv to do a cleanup, as this touches a number of calls. thanks! dave -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html