Re: [PATCH 4/4] crypto: algif_skcipher - User-space interface for skcipher operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 08, 2010 at 10:10:20AM +0100, Martin Willi wrote:
> 
> The test program below runs 1000 encryptions:
> 
> # grep nr_free /proc/vmstat 
> nr_free_pages 11031
> # ./test

Thanks, Miroslav identified a bogosity where if we're not doing
a whole page then the last sgl pointer is off by one which triggers
the leak.

With his fix I cannot reproduce this problem anymore.

Other major problems identified by him include inadequage checks
with respect to ALG_MAX_PAGES, and the use of generic SG chaining
instead of crypto SG chaining.

So here is a respin of the patches which I hope will be the last :)

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux