2010/8/20 Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>: >> +struct ncr_session_input_data { >> + const void __user *data; >> + __kernel_size_t data_size; >> +}; >> + >> +}; > Why not using fixed-size fit-all members? > struct ncr_session_input_data { > __u64 data; /* user pointer, cast to/from u64 */ > __u32 data_size; /* or __u64? */ > }; A reason is that using (void*) is cleaner as an API. It avoids the pointer to int casting and the warnings that such a cast will have. regards, Nikos -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html