On Thu, Aug 05, 2010 at 10:17:55PM +0200, Miloslav Trmač wrote: > > +static const struct algo_properties_st algo_properties[] = { > + { .algo = NCR_ALG_NULL, .kstr = "ecb(cipher_null)", > + .needs_iv = 0, .is_symmetric=1, .can_encrypt=1, > + .key_type = NCR_KEY_TYPE_INVALID }, Hard-coding names like this is completely unacceptable. User-space should be able to specify the algorithm as a string. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html