On Mon, Aug 09, 2010 at 12:45:14AM -0700, David Miller wrote: > > Kulikov, can you at least build test your patches? Casts are not > always incorrect, particularly when private cookies are "unsigned > long" as is the case here: > > drivers/char/hw_random/n2-drv.c: In function ‘n2rng_data_read’: > drivers/char/hw_random/n2-drv.c:390: warning: initialization makes pointer from integer without a cast > > Herbert, please revert this change, thanks. And I suspect there > might be more of these hwrng driver duds that went into the tree, > it's worth checking out. :-) Thanks Dave. I'll revert it for now. However, it probably makes sense to change priv into a void * as most drivers use it as a pointer instead of an integer. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
