>As you describe above, a lot of the code seems to be copied from >drivers/dma/ppc4xx/adma.c/h. Wouldn't it make more sense to factor out the >common code instead of duplicating it? Hi Stefan, Thanks for the review. There are definitely some functions can be moved to a common file. Hi Dan, Could you also please review and see if there are any changes needed, so I can include some changes as Well in the modified patch. Regards, Marri -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html