Re: [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/06/2010 12:03 AM, Herbert Xu wrote:
Justin P. Mattock<justinmattock@xxxxxxxxx>  wrote:
The below fixes a warning message generated by GCC
  CC [M]  drivers/crypto/hifn_795x.o
drivers/crypto/hifn_795x.c: In function 'hifn_flush':
drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used
drivers/crypto/hifn_795x.c: In function 'hifn_process_queue':
drivers/crypto/hifn_795x.c:2142:23: warning: variable 'ctx' set but not used

Please have a look, and let me know if this is legit or not.

Signed-off-by: Justin P. Mattock<justinmattock@xxxxxxxxx>

---
drivers/crypto/hifn_795x.c |   10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 16fce3a..e7aa4dc 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -2036,6 +2036,11 @@ static void hifn_flush(struct hifn_device *dev)
        spin_lock_irqsave(&dev->lock, flags);
        while ((async_req = crypto_dequeue_request(&dev->queue))) {
                ctx = crypto_tfm_ctx(async_req->tfm);
+                       if (ctx) {
+                               dprintk("%s: Flushing shash. %s\n",
+                               dev->name, ctx);
+                               return;
+                       }

This certainly does not look right! Returning with IRQs disabled
is considered to be rude.

Well, I certainly did not want to be rude..(searching for the right return etc.. when a function returns null gives not vary much results)


I believe the right answer is to delete the line initialising ctx.

Thanks,


o.k. then I'll resend with delete the line initialising ctx

Thanks for having a look..

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux