On Wed, May 19, 2010 at 03:24:24PM +0200, Shikhar wrote: > Hi, > > I am currently working on a driver for our crypto HW and the initial > aim was to offload IPSec (ESP for now) to HW. I did this by > registering the cipher and hash algorithms (both asynchronous) > separately (AES-CBC, HMAC-SHA1 only for now) and let the API handle > the request using the AUTHENC interface. > > The problem seems to be after the asynchronous hash request is > completed, the length of the ABLKCIPHER decrypt request is not > calculated correctly in "authenc_verify_ahash_update_done()" and > "authenc_verify_ahash_done()". The length should be subtracted by > "authsize" as done in "crypto_authenc_decrypt()". > > The following patch (applied against 2.6.34) should fix it. I hope I > didn't miss anything. Your patch looks good to me. Could you please resubmit with a sign-off (see Documentation/SubmittingPatches)? Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html