On Wed, May 19, 2010 at 12:20:34AM +0100, David Woodhouse wrote: > > It would be better if the minimum alignment was exposed to generic code > though -- you're right that the CPP tests in linux/crypto.h really > shouldn't have to exist. If it wasn't for that, then the crypto problem > wouldn't have occurred. While this problem wouldn't have occurred, we would instead have data corruption/alignment faults on architectures such as sparc32 or ARM that require 64-bit alignment for 64-bit objects. So no getting rid of them isn't going to fix things either. Of course I have no objections to moving this into slab.h or a similar location should anyone be willing to do the hard work. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html