On Tue, Apr 13, 2010 at 01:15:34PM +0300, Dmitry Kasatkin wrote: > > But anyway hmac does not support ahash now. right? > So the only way currently is to add to the driver. No the only way is to add an ahash version of hmac. Anyway, the fact that you can't easily implement import/export is not just a question of supporting hmac. It is in fact a sign that your driver breaks the crypto API. The fundamental requirement for the ahash interface is that you must be able to launch multiple operations, which means that all state must be stored in the request and not held in hardware (except as a cache). IOW, you must be able to support crypto_ahash_update(&reqa); ... crypto_ahash_update(&reqb); ... ahash_request_set_crypt(&reqa, ...); crypto_ahash_finup(&reqa); ... ahash_request_set_crypt(&reqb, ...); crypto_ahash_finup(&reqb); AFAICS your driver cannot do this correctly in its current form. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
