Re: [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2010-04-03 at 09:49 +0200, Sebastian Andrzej Siewior wrote:

> +			if (mode == CRYPT_ARC4)
> +				arc4_setup_iv((struct arc4_iv *)iv,
> +					template[i].key, template[i].klen);
> +			else
> +				ret = crypto_ablkcipher_setkey(tfm, template[i].key,
>  						       template[i].klen);

Can we avoid those special cases?  If the goal is "to make arc4
compliant with the crypto API", this looks like a step in a wrong
direction.

The same applies to many other changes in the series.

I do realize that the original arc4 is not a block cipher at all.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux