On Thu, 1 Apr 2010 05:33:51 am Brandon Philips wrote: > On 09:36 Tue 30 Mar 2010, Rusty Russell wrote: > > The real fix here is to drop the lock, like Brandon suggested, but > > we need to do it more carefully: when we re-acquire the lock we need > > to re-lookup the symbol in case the module has vanished or changed. > > > > Brandon, I can't see how libcrc32c's module_init calls > > crypto_alloc_shash, but the problem is reproducible with simple > > example modules. Does it fix your problem? > > Did you see my email yesterday explaining how this came about? Does > that answer your question? Yep, thanks. > Reviewed the patch and it looks good and I tested it on the machine > and it works. A couple of trivial things inline below if you care. > > Signed-off-by: Brandon Philips <brandon@xxxxxxxx> > Cc: stable@xxxxxxxxxx > > Thanks Rusty. Thanks; already had the two caught by checkpatch; changing the other printk is not something I like to do in the same patch. Thanks! Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
