That should be simpler and better. Thanks. Shane -----Original Message----- From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] Sent: 2010年3月2日 21:57 To: Wang, Shane Cc: Sebastian Andrzej Siewior; Jan Glauber; Cihula, Joseph; linux-crypto Subject: Re: [PATCH] to fix vmac test fails on s390 On Mon, Feb 22, 2010 at 11:21:04AM +0800, Wang, Shane wrote: > > @@ -474,7 +475,10 @@ static u64 vmac(unsigned char m[], unsig > } > p = be64_to_cpup(out_p + i); > h = vhash(m, mbytes, (u64 *)0, &ctx->__vmac_ctx); > - return p + h; > + r = p + h; > + r = le64_to_cpup(&r); > + > + return r; Is there any reason why we don't simply do return le64_to_cpu(p + h); Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ?韬{.n?????%??檩??w?{.n???{饼黍??{ay????j?f＂??????_璁(????"??m???G??⒏??璀?ｘ??
