Christian Hohnstaedt <chohnstaedt@xxxxxxxxxxxxxx> writes: >> static struct npe *npe_c; >> -static struct dma_pool *buffer_pool = NULL; >> -static struct dma_pool *ctx_pool = NULL; >> +static struct dma_pool *buffer_pool; >> +static struct dma_pool *ctx_pool; >> >> -static struct crypt_ctl *crypt_virt = NULL; >> +static struct crypt_ctl *crypt_virt; > > This is not a whitespace-fix. Right, that's trivial non-whitespace fix :-) > The error-path in init_ixp_crypto() depends on them being either NULL > or correctly allocated. > > Or is it guaranteed that static variables are always initially zero ? Yes, the BSS is cleared at boot (modprobe etc). This simply makes the on-disk image a bit smaller. >> static dma_addr_t crypt_phys; >> >> static int support_aes = 1; > > But this initialization is superflous, since it will be initialized > before use. I didn't touch it, but will remove the initialization if it's unneeded, of course. >> - static int idx = 0; >> + static int idx; > > This static index must be initialized with 0. It is, same as the crypt_virt and co. >> -static void free_buf_chain(struct device *dev, struct buffer_desc *buf,u32 phys) >> +static void free_buf_chain(struct device *dev, struct buffer_desc *buf, u32 phys) > > Introduces a line-length > 80. This limit has been lifted recently :-) >> int num = ARRAY_SIZE(ixp4xx_algos); >> - int i,err ; >> + int i, err ; > > Missed one before the ; Right. I will fix/change these, not today but soon. Thanks for looking. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
