On Tue, 2009-11-10 at 11:10 +0800, Herbert Xu wrote: > On Tue, Nov 10, 2009 at 10:49:59AM +0800, Huang Ying wrote: > > > > Yes. This is for performance only. Because crypto_gcm_reqctx(req) is not > > so trivial (it needs access tfm), and used by every xxx_done function, > > so I think it is better to just call crypto_gcm_reqctx once and pass it > > down. Do you think so? > > Since we only support blocksize == 16, that means the alignment > cannot exceed 16 bytes. So just always align to 16 bytes and that > should make crypto_gcm_reqctx trivial once optimised by the > compiler. Does it seem a little tricky? Anyway, I will prepare a patch for pure bug fix, and leave performance optimization for later. Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
