Hi Linus: This push fixes a serious regression for IPsec when using the chainiv algorithm. We were checking for NULL after converting a pointer that can be NULL to its container, which means that the NULL pointer check is useless. This would occur when the chainiv backlog queue is depleted. The result is a crash. Based on the one report received it does not occur all the time though, possibly because we only use the backlog when two CPUs try to push data through a single SA at the same time, which is rare. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git or master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git Herbert Xu (1): crypto: skcipher - Fix skcipher_dequeue_givcrypt NULL test crypto/algapi.c | 11 +++++++++-- include/crypto/algapi.h | 1 + include/crypto/internal/skcipher.h | 4 ++-- 3 files changed, 12 insertions(+), 4 deletions(-) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html