Re: [PATCH] crypto: xcbc - Fix alignment calculation of xcbc_tfm_ctx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 19, 2009 at 09:09:02AM +0200, Steffen Klassert wrote:
> The alignment calculation of xcbc_tfm_ctx uses alg->cra_alignmask
> and not alg->cra_alignmask + 1 as it should. This led to frequent
> crashes during the selftest of xcbc(aes-asm) on x86_64
> machines. This patch fixes this. Also we use the alignmask
> of xcbc and not the alignmask of the underlying algorithm
> for the alignmnent calculation in xcbc_create now.
> 
> Signed-off-by: Steffen Klassert <steffen.klassert@xxxxxxxxxxx>

Good catch!

I wonder why I didn't see it though as I too was testing this on
x86-64.  Must've been luck I suppose as it depends on what follows
the context in memory.  Anyway, patch applied to cryptodev-2.6.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux