Re: crypto: ansi_cprng - Do not select FIPS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 19, 2009 at 08:55:00AM -0400, Neil Horman wrote:
>
> Thanks!  Thats definately an oversight.  Likely I included it because I was
> implementing it as part of the FIPS effort.  The CPRNG definately works fine,
> even if fips is disabled.  Although I think the relationship should be reversed,
> not just removed, as FIPS support requires the use of the CPRNG.  Something like
> this:
> 
>  
> commit d9645d88d97e81c6528f311ee126df79a0d27501
> Author: Neil Horman <nhorman@xxxxxxxxxxxxx>
> Date:   Fri Jun 19 08:52:37 2009 -0400
> 
>     Fix CPRNG/FIPS dependency
>     
>     The ANSI CPRNG has no dependence on FIPS support.  FIPS support however,
>     requires the use of the CPRNG.  Adjust that depedency relationship in Kconfig
>     
>     Signed-off-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

Hmm, I just noticed that all my crypto modules have been marked
as built-in again because of this patch.

As you're selecting a tristate from a bool, it causes CPRNG
and everything under it to be built-in.

I'm going to revert this patch.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux