Re: [PATCH 1/1] crypto: Undefined behaviour in crypto_aes_expand_key

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 22, 2009 at 05:57:03PM +0300, Phil Carmody wrote:
> It's undefined behaviour in C to write outside the bounds of an array.
> The key expansion routine takes a shortcut of creating 8 words at a
> time, but this creates 4 additional words which don't fit in the array.
> 
> As everyone is hopefully now aware, GCC is at liberty to make any
> assumptions and optimisations it likes in situations where it can
> detect that UB has occured, up to and including nasal demons, and
> as the indices being accessed in the array are trivially calculable,
> it's rash to invite gcc to do take any liberties at all.
> 
> Signed-off-by: Phil Carmody <ext-phil.2.carmody@xxxxxxxxx>

Applied to cryptodev.  Thanks!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux