Re: [PATCH v2] crypto: authenc - convert to ahash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 22, 2009 at 09:32:11AM +0200, Steffen Klassert wrote:
> On Wed, Jul 22, 2009 at 03:02:59PM +0800, Herbert Xu wrote:
> > On Tue, Jul 21, 2009 at 11:02:17AM +0200, Steffen Klassert wrote:
> > >
> > > +	err = crypto_ahash_finup(ahreq);
> > > +	if (err == -EINPROGRESS)
> > > +		return;
> > 
> > This is redundant.  All completion functions must expect to be
> > called with EINPROGRESS followed by the actual completion later.
> 
> I copied this from crypto_authenc_encrypt_done(), so this is probaply
> redundant too. If so, I'd send a patch to remove the already existing
> checks too and put the updated ahash convertion patch on top of it.

Hmm this check doesn't exist in my tree.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux