On Fri, Jul 17, 2009 at 10:03:34AM -0700, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@xxxxxxxxxxx>
> Date: Thu, 16 Jul 2009 13:17:47 +0200
>
> > + /*
> > + * head must be a scatterlist with two entries.
> > + * We remove a potentially set termination bit
> > + * on the first enty.
> > + */
> > + head->page_link &= ~0x02;
> > +
> > if (chain) {
> > head->length += sg->length;
>
> Isn't there some interface to do this, rather than revealing the
> implementation details of how the scatter list marking works?
We have sg_mark_end() which sets the termination bit on a sg list entry,
but we don't have an interface to remove the termination bit from a sg
list entry.
>
> If not, such an interface should be created and used here. Otherwise
> any change in that implementation will break this code.
A grep over the kernel tree showed that just the block and the
crypto-layer doing this to chain sg lists. So we could create
sg_unmark_end() and use it there. If desired, I would do it.
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
