Re: [PATCH] crypto: Update stdrng test name so that the testmgr finds it properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 02, 2009 at 04:32:59PM +0800, Herbert Xu wrote:
> On Thu, Jul 02, 2009 at 08:02:55AM +0200, Sebastian Andrzej Siewior wrote:
> >
> > >@@ -1480,7 +1480,7 @@ static int alg_test_cprng(const struct alg_test_desc *desc, const char *driver,
> > > /* Please keep this list sorted by algorithm name. */
> > > static const struct alg_test_desc alg_test_descs[] = {
> > > 	{
> > >-		.alg = "ansi_cprng",
> > >+		.alg = "stdrng",
> > > 		.test = alg_test_cprng,
> > > 		.fips_allowed = 1,
> > > 		.suite = {
> > 
> > Don't you use this vector for _all_ stdrngs now? krng for instance will
> > fail.
> 
> Good cath!
> 
Indeed, I didn't even think of that.

> What this really should do is test a specific implementation of
> stdrng.  Like this,
> 
Yeah, that looks right
Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux