Hi all, On Tue, Jun 09, 2009 at 08:42:03PM +0200, Sebastian Andrzej Siewior wrote: > * Chuck Ebbert | 2009-06-09 10:35:33 [-0400]: > > >The VIA Nano has a bug that makes the padlock unit fetch extra data > >during encryption operations. Add workarounds for that, and enable > >the driver on x86_64. > Nice. The X86_64 padlock will make it mainline in next merge window so > I'm asking you kindly to rebase it against Herbert's cryptodev tree [0]. > > I guess the bug can trigger on 32bit if you boot the affected 64bit CPU > in 32bit mode? I'm not sure if it is better to send this patches via > stable tree _or_ deactivate the padlock on affected CPUs. I have now re-confirmed the errata with VIA/Centaur guys, and it seems correct. Also, reviewing [but not testing] the patch, it looks correct to me. The check for stepping '2' is also correct, as stepping 3 no longer has this issue. Chuck, I'd be more than thankful if you could rebase and resubmit as requested. If not, please drop me a not so i can put it on my todo list. Acked-by: HaraldWelte <HaraldWelte@xxxxxxxxxxx> -- - Harald Welte <HaraldWelte@xxxxxxxxxxx> http://linux.via.com.tw/ ============================================================================ VIA Free and Open Source Software Liaison -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
