On Wednesday 15 April 2009 07:20:53 Herbert Xu wrote: > On Mon, Apr 13, 2009 at 07:11:00PM -0400, Jarod Wilson wrote: > > > > + case -EBADMSG: > > + if (template[i].novrfy) > > + /* verification failure was expected */ > > + goto next_aead_vector; > > /* fall through */ > > We should also fail if novrfy is true and we get a 0 return value. Oh, yeah, whoops, missed that case. Will add that. > I'd also prefer to have the novrfy infrastructure changes to go > into a separate patch. Yeah, wasn't sure if I should do infra separate or not. I'll split things up a bit for the next submission that includes the catch for novrfy true, ret 0. -- Jarod Wilson jarod@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html