Herbert Xu wrote: > On Fri, Feb 27, 2009 at 04:56:11PM +0800, Huang Ying wrote: >> @@ -830,7 +838,7 @@ static void kcryptd_async_done(struct cr >> return; >> } >> >> - mempool_free(ablkcipher_request_cast(async_req), cc->req_pool); >> + mempool_free(dmreq->req, cc->req_pool); > > Why do we need all this complexity? Can't just fix it by using > cc->req? No. There can be parallel req allocated, also cc->req can be NULL. (seems that these structs are overcomplicated already:-) (And becuse sometimes the bio request is split into 2 pieces because of hw restrictions, there can be two ablkcipher_requests for one bio...) I think that patch is the best what we can do now as bugfix. (I am just running some tests with that.) Milan -- mbroz@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
