On Wed, 25 Feb 2009, Geert Uytterhoeven wrote: > On Wed, 25 Feb 2009, Frank Seidel wrote: > > Geert Uytterhoeven wrote: > > > BTW, why are you using printk(KERN_INFO "..."), and not pr_info("...")? > > > > Without special reason. Is pr_info preferred? > > It's shorter. > > Especially `pr_err' fits in the space of `printk', so you don't have to split > lines that become to long due to adding the KERN_*. I sent it out too soon... Other advantages: - The pr_*() calls use pr_fmt(), so you can set default prefixes (like __FILE__, __function, __LINE) at one place at the top of your driver source file. - pr_debug() is automatically left out if DEBUG is not defined (unless CONFIG_DYNAMIC_PRINTK_DEBUG is set). With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@xxxxxxxxxxx Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html