On Sat, 2009-01-10 at 18:08 +0800, Herbert Xu wrote: > On Fri, Jan 09, 2009 at 08:18:14PM +1100, Herbert Xu wrote: > > > > Not at all, tfms are just "shell" objects and they were designed > > to be used in thie way. Calling setkey twice is an issue but it's > > not a show-stopper. We have the same problem in other places to > > so this something that we can potentially optimise. > > Here's how we can solve the double setkey problem. We can make > a new cryptd_alloc_ablkcipher interface that returns a cryptd > ablkcipher object. Since it's cryptd specific we can then access > its underlying blkcipher object, which can be shared between the > cryptd object and the user of the cryptd object. This way you > only need to do setkey on the cryptd object and it'll get set > on the underlying blkcipher automatically. With this method, we can allocate only one cryptd tfm internally, without dedicated blkcipher tfm. If kernel is using FPU, crypd tfm is used, otherwise, the underlying blkcipher tfm is used directly. Best Regards, Huang Ying
Attachment:
signature.asc
Description: This is a digitally signed message part
