On Mon, 08 Dec 2008 13:55:07 -0800
James Hsiao <jhsiao@xxxxxxxx> wrote:
> >> + /* figure how many gd is needed */
> >> + if (aad_len) {
> >> + num_gd = get_sg_count(assoc, aad_len) +
> >> + get_sg_count(src, datalen);
>
> > this is dead code - aad_len is never non-zero - is there some code
> > missing from crypto4xx_alg.c? Also, IIRC, assoc is a superset of src,
> > so I believe something like num_gd = get_sg_count(assoc, aad_len +
> > datalen) would work better - this should also permit removal of the
> > nbytes reached check in [1] in get_sg_count.
>
> For the get num_gd, assoc and src are two different scatter_lists. One
> for the packet and one for the aad, so, it makes more sense to me to
> count them seperately. Yes?
ok I looked it up - they are disjoint sg lists, so, yes, you're right.
> The way to driver pass aad and aad_len is from crypto4xx_build_pd.
> This aad support will be used in the future. Do you want me to remover
> from the current release? The reason I have it in, is to avoid too much
> code change for the future release.
removing it would definitely make both this and any forthcoming aead
patches more on topic and thus easier to review (plus I suspect adding
unused code to the kernel is generally frowned upon...)
Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
