On Fri, 05 Dec 2008 15:24:11 -0800 James Hsiao <jhsiao@xxxxxxxx> wrote: > Without the check, nbytes could become negative. The aead test case > with .np will crash(ie. gcm tests), those test have sg->length > > nbytes. > > About aad_len, we didn't release code that use aad yet. We did test this > function with aad_len none zero(the gcm tests). ok - btw, it would be nice if these submissions were more self-consistent, that way we could see how aad_len is being assigned. > About the irq_disable or spin_lock. > The driver could be used by a kernel thread and esp4 at same time. As I > know process is preemptable. When the driver is used by a process it is > possible to be preempted. The hardware require scatter/gather descriptor > to be consecutive. So, if the process get a gather descriptor and then > it is preempted by another process or esp4 which get a gather descriptor > and return to the original process, the origianl process could get a non > consecutive gather descriptor. > So, if spin_lock is recommended then I have to use spin_lock_irq_save, > which use irq_disable too. Do you think that is acceptable? yes. Thanks, Kim -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
