On Mon, Dec 08, 2008 at 03:09:19AM +0300, Evgeniy Polyakov wrote: > > > static void > > -sha512_transform(u64 *state, u64 *W, const u8 *input) > > +sha512_transform(u64 *state, const u8 *input) > > { > > u64 a, b, c, d, e, f, g, h, t1, t2; > > > > int i; > > + u64 *W = get_cpu_var(msg_schedule); > > This should be protected by preempt_disable(), shouldn't it? get_cpu_var does it implicitly. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html