On Sun, Dec 7, 2008 at 16:55, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Sun, Dec 07, 2008 at 10:49:27PM +0800, Herbert Xu wrote: >> >> In any case the loop itself does not involve any crypto components >> so I don't think making changes in the crypto layer is going to >> make this go away forever as anyone calling request_module early >> enough will get into this loop. > > Having said that I think this patch should remove this particular > trigger. Unfortunately I couldn't find a more succinct way of > expressing this relationship: if ALGAPI is built-in because it's > selected by an algorithm, and CRYPTO_MANAGER is enabled then we > require CRYPTO_MANAGER to be built-in as well. > > Evgeniy, please let me know whether this fixes the problem. Even when this works around it, the problem that the kernel triggers module loading on /dev/console access stays and needs to be fixed instead. It's a pure kernel bug, regardless of how many times Alan likes to establish non-sensical hotplug rules to prevent this. The next innocent driver change, like yours is, will run into the same problem. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
