Herbert Xu wrote: > On Thu, Dec 04, 2008 at 10:32:07AM +0100, Adrian-Ken Rueegsegger wrote: >> static void >> -sha512_transform(u64 *state, u64 *W, const u8 *input) >> +sha512_transform(u64 *state, const u8 *input) >> { >> u64 a, b, c, d, e, f, g, h, t1, t2; >> - >> + u64 W[80]; > > This is too big for the stack. So we need to put it somewhere > else. A static per-cpu area is one choice. Yes, sorry about that. I didn't properly read your previous mail. I will redo the sha512 patches. Thanks for the review, Adrian -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html