Evgeniy Polyakov wrote:
Hi Patrick.
On Wed, Sep 24, 2008 at 06:40:29PM +0200, Patrick McHardy (kaber@xxxxxxxxx) wrote:
[HIFN]: Fix DMA setup
without a changelog :) IIRC the problem is that HIFN sets up each
DMA descriptor for the full request length, even though it should
only cover on SG entry. The result is memory corruption.
Can not tell without patch itself, but code operates on the number of
bytes provided from the higher levels, not full dma size (0x3ff bytes).
Yes, but it uses that size for every descriptor.
I'm going to send you the patches in private (they're quite large)
so you can have a look.
[HIFN]: Don't copy src sg list
also without a changelog. I think this one was just an optimization,
the source descriptors don't have alignment or size restrictions and
thus we don't need to linearize it first.
Also can not say for sure, but there should not be src linearization,
instead we copy data from src to aligned dst and then perform crypto
processin in place, and then copy data back.
Right, I remember. The copying to the (temporary) destination area
is not necessary, the chip can just read it from the source are directly.
[HIFN]: Fix request context corruption
HIFN uses the transform context to store per-request data, which breaks
when more than one request is outstanding. Move per request members from
struct hifn_context to a new struct hifn_request_context and convert
the code to use this.
Its per-tfm, so things like key and iv are ok, and others should only be
accessed under the lock, but there may be problems.
Things like op, mode, ... are per request and are set without any
locking.
If someone is interested in picking this up I could send my old patches,
I probably won't manage to do it myself in the next time.
Please do, if they work for you, we can just apply them, but I would
like first to check them out.
I'm not sure whether they're ready for applying. IIRC I still got stalls
occasionally,
but I don't remember the details. They made things better for me though :)
Anyways, patches coming up in a minute.
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
