On Fri, Aug 08, 2008 at 01:02:48PM -0700, Shasi Pulijala wrote:
>
> This patch adds PKA support to Linux CryptoAPI. All the basic algorithms like add, sub, div, expmod and expmod-crt can be supported by this interface. Currently the max number of src and dst operands have been defined as 6 and 2 respectively. These values should fit all the above mentioned algorithms (for example add needs 2 for input and 1 for output, expmod-crt 6 for input and 1 for output). Although, there is no specific mapping of operands, it is assumed that for add, operand A would be the first entry, operand B would be the second entry of the source. The output would be the first output.
Could you please tell us why we need this at all? For instance,
what hardware devices will be supported and who will be the users?
> +struct pka_request {
> + struct crypto_async_request base;
> +
> + struct scatterlist *src[6];
> + struct scatterlist *dst[2];
> + u32 operand_src_size[6];
> + u32 operand_dst_size[2];
> +
> + int iops;
> + int oops;
No, multiplexed interfaces are bad in general. Please provide
separate interfaces for each operation.
You should also post a software implementation so that
1) You illustrate what this is all about.
2) We have a yardstick for the hardware devices.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
