On Wed, Aug 06, 2008 at 07:17:24PM +0800, Herbert Xu wrote: > On Wed, Aug 06, 2008 at 07:05:27AM -0400, Austin Zhang wrote: > > > > > > + return -1; > > > > > > That's supposed to be errno, right? > > Are you suggest "ENODEV"? It's a feature from the device but the device is exact here. > > Yes I think this should be ENODEV to be consistent with the > existing drivers such as padlock-aes.c. > > I'll make that change in cryptodev. In fact I'm going to kill that printk altogether since the fact that this feature doesn't exist isn't an error. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
