Re: [PATCH 1/1 v4] Add CryptoAPI User Interface Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi.

On Wed, Jul 30, 2008 at 04:53:01PM -0700, Loc Ho (lho@xxxxxxxx) wrote:
> This is Linux CryptoAPI user space interface support patch v4. This version includes:
> 
> * Add async support using Linux AIO.
> * Interafce to choose Copy to/from user and pinning pages based on size of data.
> * Asynchronous operations are issued through aio write function call. And result data
> is read back in the same context using the retry aio operations.
> * The crypto operation structure is passed via the data parameter of the write function.
> Internally, it will perform a copy from user call just as the synchronous I/O control version.

What does prevent from simultaneous command execution? Or setkey() vs.
run() race? Do you rely on BKL which 'guards' ioctl execution? How is
->write() protected from ioctl()?

Please also remove forward declarations and rearrange code if needed.
You can also drop looong ******** lines from comments.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux