Hi. On Thu, Jun 12, 2008 at 01:54:00PM -0700, Loc Ho (lho@xxxxxxxx) wrote: > This is CryptoAPI user space interface support patch v2. This version > includes: > > 1. a file descriptor per tfm > 2. Direct I/O for user data buffer (with option for single mapping) > 3. algorithm properties is set via I/O control call > 4. Per buffer operation is operated via I/O control call Number of overall moments: * your mailer heavily mangled patch, please fix it or attach patch next time * be ready to defend, why /dev/crypto should be char device and not misc, also why it is not a syscall :) * overall approach of multiple copy_from_user is noticebly slower than single copy_from_user of the whole structure and they parse it according to internal fields * the same applies to multiple allocations: try to avoid it as much as possible and allocate whole structure in one go -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html