On Tue, May 13, 2008 at 05:00:58PM -0700, Loc Ho (lho@xxxxxxxx) wrote: > Hi Herbert, > > I am re-sending this email as I don't believe it got to the mailing > list. Due to email problem, I am forward this patch on behalf of Shasi > Pulijala who worked on this user space interface for Linux CryptoAPI. > This should add support for OpenSSL. Please note that user of this patch > musts patch OpenSSL. The OpenSSL patch can be found in OCF-Linux as this > interface uses the same I/O control interface. There is number of problems with this patchset: 1. codying style - likely the most harmless 2. on-stack allocation should be dropped where possible 3. session id can be generated as pointer to session, not via getting random bytes in a loop 4. linked list of in-flight session really does not scale 5. session destruction seems to be racy 6. do not use semaphores, mutex works ok here 7. lots of kmalloc/copy_*_user also much slower than single bigger allocation and sinegle copy_*_user 8. use kzalloc instead of kmalloc/memset 9. having pointer in structure shared between kernel and userspace is very wrong 10. userspace does not know about u32 and friends, use __u32 abd others instead Please also provide a high-level description of the protocol used for crypto processing. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
